Extend macrobenchmark suite to cover namespaces, buffered vs. nocopy #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
commented
Aug 1, 2022
| group.finish(); | ||
| } | ||
|
|
||
| /// Decode into a buffer, then parse |
Collaborator
Author
There was a problem hiding this comment.
I'm aware that this is a premature description
dralley
force-pushed
the
extend-benchmarks
branch
from
cbd48dd to
69b4090
Compare
dralley
commented
Aug 1, 2022
dralley
commented
Aug 1, 2022
| static SAMPLE_NS: &str = include_str!("../tests/documents/sample_ns.xml"); | ||
| static PLAYERS: &str = include_str!("../tests/documents/players.xml"); | ||
|
|
||
| static INPUTS: &[(&str, &str)] = &[ |
Collaborator
Author
There was a problem hiding this comment.
We do probably want to start asking the question - which benchmarks are strictly necessary to get coverage of the things we want to test. Because otherwise it will take a very long time to run them all.
Or at least document what the most representative subset is so that it can be specified on the command line.
Collaborator
There was a problem hiding this comment.
I think, that documentation would be enough
Mingun
approved these changes
Aug 1, 2022
| static SAMPLE_NS: &str = include_str!("../tests/documents/sample_ns.xml"); | ||
| static PLAYERS: &str = include_str!("../tests/documents/players.xml"); | ||
|
|
||
| static INPUTS: &[(&str, &str)] = &[ |
Collaborator
There was a problem hiding this comment.
I think, that documentation would be enough
dralley
force-pushed
the
extend-benchmarks
branch
from
69b4090 to
dae1cc9
Compare
dralley
force-pushed
the
extend-benchmarks
branch
from
dae1cc9 to
d41a7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.