Fix #435: replay only events from time of creating SeqAccess struct #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 51.33% 52.15% +0.81%
==========================================
Files 28 28
Lines 13312 13480 +168
==========================================
+ Hits 6834 7030 +196
+ Misses 6478 6450 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dralley
reviewed
Aug 6, 2022
| ); | ||
|
|
||
| // Initial conditions - both are empty | ||
| assert_eq!(de.read, vec![]); |
Collaborator
There was a problem hiding this comment.
Just .is_empty() is cleaner
Collaborator
Author
There was a problem hiding this comment.
I would like to keep comparing with empty vector for two reasons:
- keep uniformity of checks in the test
- if check failed, I would see actual content of a field
Collaborator
Author
|
I remembered that I've implemented not all tests which I wish |
Mingun
force-pushed
the
overlapped-with-nested-lists
branch
from
f26f317 to
a79e5d9
Compare
failures (1):
de::tests::skip::partial_replay
failures (14):
seq::fixed_name::fixed_size::field_after_list::overlapped_with_nested_list
seq::fixed_name::fixed_size::field_before_list::overlapped_with_nested_list
seq::fixed_name::fixed_size::two_lists::overlapped_with_nested_list
seq::fixed_name::variable_size::field_after_list::overlapped_with_nested_list
seq::fixed_name::variable_size::field_before_list::overlapped_with_nested_list
seq::fixed_name::variable_size::two_lists::overlapped_with_nested_list
seq::variable_name::fixed_size::field_after_list::overlapped_with_nested_list
seq::variable_name::fixed_size::field_before_list::overlapped_with_nested_list
seq::variable_name::fixed_size::two_lists::choice_and_fixed::overlapped::with_nested_list_fixed_after
seq::variable_name::fixed_size::two_lists::fixed_and_choice::overlapped::with_nested_list_fixed_after
seq::variable_name::variable_size::field_after_list::overlapped_with_nested_list
seq::variable_name::variable_size::field_before_list::overlapped_with_nested_list
seq::variable_name::variable_size::two_lists::choice_and_fixed::overlapped::with_nested_list_fixed_after
seq::variable_name::variable_size::two_lists::fixed_and_choice::overlapped::with_nested_list_fixed_after
Mingun
force-pushed
the
overlapped-with-nested-lists
branch
from
a79e5d9 to
656081b
Compare
dralley
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #435. The reason of the bug is that nested lists produces two calls of
start_replay()of skipped events, but not all events should be replayed after first call.This PR add marks that determines which events should be replayed after calling
start_replay(). The mark is created when new replay scope is started (whendeserialize_seq/deserialize_tuple/deserialize_tuple_structis called) and used whenstart_replay()is called.