Restore ability to deserialize attributes that represents XML namespace mappings (xmlns:xxx)#539
Merged
dralley merged 1 commit intotafia:masterfrom Jan 6, 2023
Merged
Conversation
…ce mappings (`xmlns:xxx`)
dralley
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #537.
Change in behavior was made in 8b50c64 of #490
quick-xml/src/de/key.rs
Lines 73 to 80 in 4a09041
Here only local part of an attribute name is mapped to the field name. Because
xmlns:...attributes is a special names, I make a special handling for that names -- use the full name of an attribute.Note, that usually
xmlnsshould not be considered as a data that could be accessed via serde interface. This is metadata of an XML serialization format. When (if) #218 would be implemented, that attributes most likely wouldn't be accessible at all.