Skip to content

Conversation

@Mingun
Copy link
Collaborator

@Mingun Mingun commented Oct 17, 2023

maybe_xml is still about 1.5x--2x faster that quick-xml in most tests, except those:

  • rpm_other
  • linescore
  • test_writer_ident
  • players

Here is criterion report: comparison.zip

@codecov-commenter
Copy link

Codecov Report

Merging #668 (b9a0fa2) into master (7fbe4bc) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files          37       37           
  Lines       17697    17697           
=======================================
  Hits        11460    11460           
  Misses       6237     6237           
Flag Coverage Δ
unittests 64.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Mingun Mingun merged commit 27a93b3 into tafia:master Oct 17, 2023
@Mingun Mingun deleted the compare branch October 17, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants