Skip to content

Fix subtraction with overflow panic when parse malformed DTD#954

Merged
Mingun merged 4 commits into
tafia:masterfrom
Mingun:issue950
May 3, 2026
Merged

Fix subtraction with overflow panic when parse malformed DTD#954
Mingun merged 4 commits into
tafia:masterfrom
Mingun:issue950

Conversation

@Mingun
Copy link
Copy Markdown
Collaborator

@Mingun Mingun commented May 3, 2026

Initially fix is implemented in v0.39 branch, that is started from v0.39.2 tag, and then merged in issue950 branch (the branch that is PRed to master). I plan also include this fix into v0.39.3 patch (because master contains some breaking changes, that cannot be included in v0.39.3).

Closes #950

@Mingun Mingun added the bug label May 3, 2026
@Mingun Mingun requested a review from dralley May 3, 2026 13:32
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.40%. Comparing base (a759d65) to head (c05c784).
⚠️ Report is 13 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
+ Coverage   55.08%   56.40%   +1.31%     
==========================================
  Files          44       44              
  Lines       16911    17606     +695     
==========================================
+ Hits         9316     9931     +615     
- Misses       7595     7675      +80     
Flag Coverage Δ
unittests 56.40% <100.00%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mingun Mingun merged commit 426023b into tafia:master May 3, 2026
7 checks passed
@Mingun Mingun deleted the issue950 branch May 3, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stability regression in v0.39.2: attempt to subtract with overflow

3 participants