Fix subtraction with overflow panic when parse malformed DTD#954
Merged
Conversation
failures:
issue950
Fixed:
issue950
# Conflicts: # Changelog.md
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
==========================================
+ Coverage 55.08% 56.40% +1.31%
==========================================
Files 44 44
Lines 16911 17606 +695
==========================================
+ Hits 9316 9931 +615
- Misses 7595 7675 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dralley
approved these changes
May 3, 2026
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially fix is implemented in v0.39 branch, that is started from v0.39.2 tag, and then merged in
issue950branch (the branch that is PRed to master). I plan also include this fix into v0.39.3 patch (because master contains some breaking changes, that cannot be included in v0.39.3).Closes #950