Fix constant recompilation issue #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was caused by using Application.compile_env/3 and Application.compile_env!/2 in module attributes (@assert_receive_timeout and @refute_receive_timeout). These functions create compile-time dependencies on application configuration, causing Mix to recompile the module every time the parent application compiles. The fix: - Replaced Application.compile_env with Application.get_env, which reads configuration at runtime instead of compile time - Converted the module attributes to private functions that are called at runtime - Updated all usages to call these functions instead of referencing module attributes This eliminates the compile-time dependency, so tracee will only be compiled once per version/environment as expected. Fixes #1
ream88
changed the title
ream88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by using Application.compile_env/3 and Application.compile_env!/2 in module attributes (@assert_receive_timeout and @refute_receive_timeout). These functions create compile-time dependencies on application configuration, causing Mix to recompile the module every time the parent application compiles.
The fix:
This eliminates the compile-time dependency, so tracee will only be compiled once per version/environment as expected.
Fixes #1