[cc] Add ti.cfg.cc_compile_cmd and ti.cfg.cc_link_cmd#1645
Merged
archibate merged 3 commits intotaichi-dev:masterfrom Aug 10, 2020
Merged
[cc] Add ti.cfg.cc_compile_cmd and ti.cfg.cc_link_cmd#1645archibate merged 3 commits intotaichi-dev:masterfrom
archibate merged 3 commits intotaichi-dev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
=======================================
Coverage 44.40% 44.40%
=======================================
Files 41 41
Lines 5876 5876
Branches 1022 1022
=======================================
Hits 2609 2609
Misses 3118 3118
Partials 149 149 Continue to review full report at Codecov.
|
Collaborator
Author
|
@yuanming-hu Did you forget to release v0.7.25? |
Collaborator
Author
|
Hi, I'm merging this for now given that v0.7.25 is all set. FF2 revert me if you find any fatal drawback. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue = #1332 #1644
[Click here for the format server]
ti.cfg.cc_compile_cmd = "gcc -c -o '{}' '{}' -O3".ti.init(cc_compile_cmd="gcc -c -o '{}' '{}' -O3").export TI_CC_COMPILE_CMD="gcc -c -o '{}' '{}' -O3".@k-ye Could you confirm it works on your osx machine by using the correct compile_cmd?
Could you add a
#ifdef TI_PLATFORM_OSXguard to add the most commonly used compiler on OS X?