[Build] External deps & imgui#8655
[Build] External deps & imgui#8655johnnynunez wants to merge 35 commits intotaichi-dev:masterfrom johnnynunez:external_deps
Conversation
ARM Builds
Revert external submodules to previous commit
|
The CI machines are currently under migration to a different DC, will trigger it once they are ready. |
thanks, also is important to migrate to newer llvm. It breaks in ubuntu 24.04 system build |
|
/rebase |
|
Hey, I think the CI is currently spitting legitimate errors, PTAL =] |
|
/rebase |
1 similar comment
|
/rebase |
…arning as error in TaichiCXXFlags.cmake
for more information, see https://pre-commit.ci
|
|
||
| stream->submit_synced(cmd_list.get()); | ||
| ImGui_ImplVulkan_DestroyFontUploadObjects(); | ||
| ImGui_ImplVulkan_DestroyFontsTexture(); |
There was a problem hiding this comment.
Implications and consequences of changing this API call? Based on the name, it sounds like we are no longer uploading font objects?
There was a problem hiding this comment.
it is vulkan 1.4 compatibility
bobcao3
left a comment
bobcao3
left a comment
There was a problem hiding this comment.
Please avoid merging a mega-PR like this... It's hard to fix & reason about. Notes taken on node 's glibc version requirements, but some of the python version changes absolutely shouldn't be mixed with the other commits.
Can you make a separate PR that just changes one aspect? Or I can start making PRs updating the vulkan / imgui dependencies first. ( Vulkan 1.4 is already fixed if you aren't aware)
|
Note: I too need GLFW upgraded, for Mac OS 15.x build. I created a PR onto taichi-dev/glfw to pull from master onto our customized branch, taichi-dev/glfw#2 @bobcao3 Do you have a moment to approve the taichi-dev/glfw PR please? |
|
i will do a lot of small PR's |
|
@johnnynunez Great! 🙌 |
5 participants
This pull request includes updates to several submodules and a minor code improvement in the
taichiproject. The most important changes include updating the submodule branches and commits, and improving the null check inIRVerifier.Submodule updates:
.gitmodules: Updated theexternal/eigensubmodule to use branch3.4instead of3.3.external/DirectX-Headers: Updated the submodule commit to3ae9c7692ddecc9107d401fdf7999b34a8b8079b.external/FP16: Updated the submodule commit to98b0a46bce017382a6351a19577ec43a715b6835.external/PicoSHA2: Updated the submodule commit to27fcf6979298949e8a462e16d09a0351c18fcaf2.external/SPIRV-Cross: Updated the submodule commit to2c32b6bf86f3c4a5539aa1f0bacbd59fe61759cf.external/SPIRV-Headers: Updated the submodule commit to54a521dd130ae1b2f38fef79b09515702d135bdd.external/SPIRV-Reflect: Updated the submodule commit toc637858562fbce1b6f5dc7ca48d4e8a5bd117b70.external/SPIRV-Tools: Updated the submodule commit tobb86786ed9aa6576a1fb72a9eeea5203df378d9b.external/Vulkan-Headers: Updated the submodule commit to952f776f6573aafbb62ea717d871cd1d6816c387.external/VulkanMemoryAllocator: Updated the submodule commit toc788c52156f3ef7bc7ab769cb03c110a53ac8fcb.external/backward_cpp: Updated the submodule commit to94718085efa256fb25a311a46b5948ee0d95890a.external/eigen: Updated the submodule commit to68f4e58cfacc686583d16cff90361f0b43bc2c1b.external/glfw: Updated the submodule commit toa79677378b52688ae1adaccfa25b404c3d1dcaec.external/glm: Updated the submodule commit to2d4c4b4dd31fde06cfffad7915c2b3006402322f.external/googletest: Updated the submodule commit toe88cb95b92acbdce9b058dd894a68e1281b38495.external/imgui: Updated the submodule commit toa7657f2ed45508bb719a8b9e2d8e7bda57eff4a0.external/spdlog: Updated the submodule commit to3335c380a08c5e0f5117a66622df6afdb3d74959.external/volk: Updated the submodule commit to58689c063427f5bad4f133625049b1a3c5dd8287.Code improvements:
taichi/analysis/verify.cpp: Improved null check inIRVerifierby using.get()method forstmt->body.taichi/common/logging.h: Added#include "spdlog/fmt/ranges.h"for better formatting support.