fix: show upstream error message on ui#1000
Merged
tusharmath merged 9 commits intomainfrom Jun 27, 2025
Merged
Conversation
tusharmath
reviewed
Jun 25, 2025
tusharmath
reviewed
Jun 25, 2025
| assert!(error_string.contains("500")); | ||
| assert!(error_string.contains("Internal Server Error")); | ||
| assert!(error_string.contains("Failed to fetch the models")); | ||
|
|
Collaborator
There was a problem hiding this comment.
Asserting in provider doesn't guarantee that we show the same error on the UI. The error message can be modified with more context along the way.
Contributor
Author
There was a problem hiding this comment.
what do you suggest? we don't have UI level tests yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.