Merged
Conversation
tusharmath
approved these changes
Dec 19, 2024
Zetkolink
added a commit
to Zetkolink/forgecode
that referenced
this pull request
Apr 8, 2026
Bugs fixed: - #1: Unified timestamp format — all tables use strftime('%s','now') (unix seconds) - #2: delete_file_refs and delete_workspace wrapped in transactions - tailcallhq#19: Removed chrono_now(), use SQLite DEFAULT instead Security: - tailcallhq#15: All workspace methods verify ownership (authenticate_and_verify_owner) - Added db.verify_workspace_owner() method Code quality: - tailcallhq#7: ForgeServiceImpl fields private, added new() constructor - tailcallhq#8: IntoStatus trait eliminates 15+ duplicate .map_err() calls - tailcallhq#9: Removed unused lock_conn helper, kept consistent pattern - tailcallhq#11: Documented ends_with filter limitation in qdrant.rs - tailcallhq#10: reqwest Client with 120s timeout + 10s connect_timeout - tailcallhq#18: Added extract_workspace_id() helper Co-Authored-By: ForgeCode <noreply@users.noreply.github.com>
Zetkolink
added a commit
to Zetkolink/forgecode
that referenced
this pull request
Apr 8, 2026
Bugs fixed: - #1: Unified timestamp format — all tables use strftime('%s','now') (unix seconds) - #2: delete_file_refs and delete_workspace wrapped in transactions - antinomyhq#19: Removed chrono_now(), use SQLite DEFAULT instead Security: - antinomyhq#15: All workspace methods verify ownership (authenticate_and_verify_owner) - Added db.verify_workspace_owner() method Code quality: - antinomyhq#7: ForgeServiceImpl fields private, added new() constructor - antinomyhq#8: IntoStatus trait eliminates 15+ duplicate .map_err() calls - antinomyhq#9: Removed unused lock_conn helper, kept consistent pattern - antinomyhq#11: Documented ends_with filter limitation in qdrant.rs - antinomyhq#10: reqwest Client with 120s timeout + 10s connect_timeout - antinomyhq#18: Added extract_workspace_id() helper
Zetkolink
added a commit
to Zetkolink/forgecode
that referenced
this pull request
Apr 8, 2026
Bugs fixed: - #1: Unified timestamp format — all tables use strftime('%s','now') (unix seconds) - #2: delete_file_refs and delete_workspace wrapped in transactions - tailcallhq#19: Removed chrono_now(), use SQLite DEFAULT instead Security: - tailcallhq#15: All workspace methods verify ownership (authenticate_and_verify_owner) - Added db.verify_workspace_owner() method Code quality: - tailcallhq#7: ForgeServiceImpl fields private, added new() constructor - tailcallhq#8: IntoStatus trait eliminates 15+ duplicate .map_err() calls - tailcallhq#9: Removed unused lock_conn helper, kept consistent pattern - tailcallhq#11: Documented ends_with filter limitation in qdrant.rs - tailcallhq#10: reqwest Client with 120s timeout + 10s connect_timeout - tailcallhq#18: Added extract_workspace_id() helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.