chore(write-release-notes): add contributor filter and length validation#2610
chore(write-release-notes): add contributor filter and length validation#2610tusharmath merged 1 commit intomainfrom
Conversation
🤖 Augment PR SummarySummary: Updates the Changes:
Technical Notes: The validator exits with 0 on PASS and 1 on FAIL for easy use in scripts/automation. 🤖 Was this summary useful? React with 👍 or 👎 |
| After writing the release notes, run the bundled validation script to confirm the output is under 2000 characters: | ||
|
|
||
| ```bash | ||
| echo "<release notes>" | bash .forge/skills/write-release-notes/scripts/validate-release-notes.sh |
There was a problem hiding this comment.
The echo "<release notes>" | bash ... example may not preserve multi-line release notes verbatim when users copy/paste (and echo can also be shell-dependent), which can make the length validation differ from the actual draft. Consider clarifying an input method that preserves newlines exactly so the validator matches what will be posted.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| MAX_CHARS=2000 | ||
|
|
||
| if [[ $# -ge 1 ]]; then | ||
| content=$(cat "$1") |
There was a problem hiding this comment.
content=$(cat ...) via command substitution strips trailing newline(s), so char_count can be under-reported and potentially PASS output that would be at/over the limit when pasted verbatim. This affects both the file-input and stdin paths.
Severity: medium
Other Locations
.forge/skills/write-release-notes/scripts/validate-release-notes.sh:18
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
No description provided.