fix(fd): exclude lock files from workspace file indexing

[tusharmath]

Summary

Fix a bug where lock files (e.g. package-lock.json, Cargo.lock, yarn.lock) were being indexed for workspace sync despite containing no useful content for code intelligence.

Context

The file discovery pipeline filtered files by allowed extension, but lock files often carry extensions that appear on the allowlist (e.g. .json, .yaml, .yml). This meant files like package-lock.json, npm-shrinkwrap.json, Cargo.lock, and Package.resolved were being pulled into the indexing pipeline unnecessarily, wasting compute and polluting search results with auto-generated dependency manifests.

Changes

• Added is_ignored_by_name function in crates/forge_services/src/fd.rs that matches lock file patterns by full filename, independent of extension
• Wired the check into filter_and_resolve so it runs before the extension allowlist filter
• Patterns covered:
  • *.lock — Cargo.lock, yarn.lock, Gemfile.lock, composer.lock, etc.
  • *.lockb — Bun lock files
  • *-lock.json — package-lock.json, npm-shrinkwrap.json
  • *-lock.yaml / *-lock.yml — various toolchain lock formats
  • *.lock.json — alternative lock file conventions
  • *.lockfile — generic lockfile extension
  • Package.resolved — Swift Package Manager

Key Implementation Details

The name check is case-insensitive via name_lower (a lowercased copy of the filename), with the exception of Package.resolved which is matched case-sensitively as the Swift ecosystem uses that exact casing.

The filter is applied before has_allowed_extension, so lock files with otherwise-allowed extensions (.json, .yaml) are rejected early without needing changes to the extension allowlist.

Testing

cargo insta test --accept -p forge_services
cargo check -p forge_services

[graphite-app]

Inconsistent case-sensitivity check. Line 50 uses name (case-sensitive) while all other checks use name_lower (case-insensitive). This will fail to filter out variations like "package.resolved" or "PACKAGE.RESOLVED".

Fix by using the lowercase version:

|| name_lower == "package.resolved"

Suggested change

	|| name == "Package.resolved"
	|| name_lower == "package.resolved"

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.