fix(http): append newline to debug file writes for valid jsonl format#2939
Merged
tusharmath merged 1 commit intomainfrom Apr 10, 2026
Merged
fix(http): append newline to debug file writes for valid jsonl format#2939tusharmath merged 1 commit intomainfrom
tusharmath merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix HTTP debug file writes to append a newline after each entry, ensuring the output is valid JSONL (JSON Lines) format.
Context
When the
debug_requestsfeature is enabled, HTTP request/response bodies are appended to a debug file. However, each write was missing a trailing newline, meaning entries were written back-to-back without any delimiter. This breaks the JSONL format, where each line must be a separate, complete JSON object. Tools that consume JSONL files (log parsers, analytics pipelines, etc.) would fail to parse the debug output correctly.Changes
ForgeHttpInfrato append a\nbyte after each body write to the debug file, producing valid JSONL output.Key Implementation Details
The fix is minimal and targeted: before calling
file_writer.append, the body bytes are cloned into aVec<u8>, a newline byte (b'\n') is pushed, and the result is converted back toBytes. This ensures no existing data is mutated and the change is fully backward-compatible.Testing
All four existing debug-write tests have been updated to assert the newline is present and continue to pass.
Links
crates/forge_infra/src/http.rs