fix(command-list): deduplicate agent names in list commands porcelain output#3011
Merged
tusharmath merged 2 commits intomainfrom Apr 14, 2026
Merged
fix(command-list): deduplicate agent names in list commands porcelain output#3011tusharmath merged 2 commits intomainfrom
tusharmath merged 2 commits intomainfrom
Conversation
…to prevent duplicate entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
:muse,:sage, and:forgeZSH commands failing with "command not found" by removing duplicate entries fromlist commands --porcelainoutput.Context
AppCommand::Forge,AppCommand::Muse, andAppCommand::Sageare REPL shortcut variants that switch agents. Inon_show_commands, they were being emitted twice: once by theAppCommand::iter()loop (asCOMMAND) and again by the agent-info loop (asAGENT). The ZSH shell plugin's_forge_action_defaultusedgrepto find the command row, received two matching lines, and ended up withcommand_type = "AGENT\nCOMMAND"— a multi-line string that failed the[[ "${command_type:l}" == "agent" ]]check, causing the "command not found" error.Changes
is_agent_switch()method toAppCommandinmodel.rsthat returnstrueforForge,Muse, andSageon_show_commandsinui.rsto filter out agent-switch shorthands from the COMMAND loop, so they appear exactly once — asAGENT— in the porcelain outputTesting
Fixes #3009