fix(deps): drop unmaintained atty crate#3054
Merged
tusharmath merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Resolves Dependabot alert #8 (GHSA-g98v-hv3f-hcfr). The atty crate is unmaintained and flagged for a potential unaligned read on Windows. No patched upstream release exists, so the advisory recommends replacement. Switch to the standard library's std::io::IsTerminal, which is stable since Rust 1.70 and covers our only use case (detecting piped stdin). This eliminates the vulnerable dependency entirely without adding any new third-party code. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Resolves Dependabot alert #8 (GHSA-g98v-hv3f-hcfr).
The
attycrate is unmaintained (last release ~3 years ago) and carries a low-severity advisory for a potential unaligned read on Windows. Upstream has not published a patched version and is unlikely to, so the advisory explicitly recommends replacing it.Why this approach
std::io::IsTerminalhas been stable since Rust 1.70 and provides exactly the TTY-detection capability we were usingattyfor. Leaning on the standard library is preferable to pulling in another third-party crate (e.g.is-terminal) because it:Scope
attyhad exactly one caller in the workspace (stdin pipe detection inforge_main). Behavior is preserved: piped stdin still populates the piped-input path, and interactive TTY sessions still bypass the stdin read.Verification
cargo tree -i atty --workspaceconfirms the crate is no longer in the graph.cargo checkpasses./dev/nullredirect. Interactive TUI launches and exits cleanly; piped commands do not hang.Co-Authored-By: ForgeCode noreply@forgecode.dev