Skip to content

fix(shell-plugin): use forge exec for config list and remove logs command#3165

Merged
tusharmath merged 2 commits intomainfrom
fix-config-env
Apr 26, 2026
Merged

fix(shell-plugin): use forge exec for config list and remove logs command#3165
tusharmath merged 2 commits intomainfrom
fix-config-env

Conversation

@tusharmath
Copy link
Copy Markdown
Collaborator

@tusharmath tusharmath commented Apr 26, 2026

Summary

Fix the shell plugin's config action to use _forge_exec instead of invoking the binary directly, and remove the now-unused forge logs CLI command.

Context

The shell plugin's _forge_action_config function was calling $_FORGE_BIN config list directly, bypassing the _forge_exec wrapper that ensures the correct environment and PATH are set up before running forge commands. This could cause the config list to run in an inconsistent environment.

Additionally, the forge logs command (which shelled out to tail) was found to be unused/unnecessary and has been cleaned up to reduce CLI surface area and dead code.

Changes

  • shell-plugin: Replace $_FORGE_BIN config list with _forge_exec config list in _forge_action_config so the exec wrapper is consistently used
  • Remove forge logs command: Delete cli.rs Logs(LogsArgs) variant, LogsArgs struct, the entire logs.rs module, and its dispatch branch in ui.rs

Testing

# Verify config list works through the shell plugin
forge config

# Verify `forge logs` is no longer a recognised command
forge logs  # should print an error / usage hint

# Run crate tests
cargo insta test --accept -p forge_main

Links

  • No related issues

@github-actions github-actions Bot added the type: fix Iterations on existing features or infrastructure. label Apr 26, 2026
@tusharmath tusharmath changed the title fix(shell-plugin): use forge exec for config list fix(shell-plugin): use forge exec for config list and remove logs command Apr 26, 2026
@tusharmath tusharmath enabled auto-merge (squash) April 26, 2026 05:00
@tusharmath tusharmath merged commit 03376e9 into main Apr 26, 2026
8 checks passed
@tusharmath tusharmath deleted the fix-config-env branch April 26, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Iterations on existing features or infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant