fix(shell-plugin): use forge exec for config list and remove logs command#3165
Merged
tusharmath merged 2 commits intomainfrom Apr 26, 2026
Merged
fix(shell-plugin): use forge exec for config list and remove logs command#3165tusharmath merged 2 commits intomainfrom
tusharmath merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the shell plugin's config action to use
_forge_execinstead of invoking the binary directly, and remove the now-unusedforge logsCLI command.Context
The shell plugin's
_forge_action_configfunction was calling$_FORGE_BIN config listdirectly, bypassing the_forge_execwrapper that ensures the correct environment and PATH are set up before running forge commands. This could cause the config list to run in an inconsistent environment.Additionally, the
forge logscommand (which shelled out totail) was found to be unused/unnecessary and has been cleaned up to reduce CLI surface area and dead code.Changes
$_FORGE_BIN config listwith_forge_exec config listin_forge_action_configso the exec wrapper is consistently usedforge logscommand: Deletecli.rsLogs(LogsArgs)variant,LogsArgsstruct, the entirelogs.rsmodule, and its dispatch branch inui.rsTesting
Links