fix(sync): count all files in failed upload batch as failed#3187
Merged
tusharmath merged 6 commits intomainfrom Apr 28, 2026
Merged
fix(sync): count all files in failed upload batch as failed#3187tusharmath merged 6 commits intomainfrom
tusharmath merged 6 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
failed_filesundercounting when a batch upload fails — a batch of N files was counted as 1 failure instead of N.Context
The upload stream processes files in batches of up to
batch_size. When a batch upload failed, the error handler incrementedfailed_files += 1regardless of how many files were in the batch. With a batch size of 100, a single failed batch would only report 1 failed file instead of 100, causing the finalSyncProgress::Completedevent and the sync error to report incorrect counts.Changes
upload_filesstream item type fromResult<usize, Error>to(usize, Result<(), Error>), so the batch's attempted file count is always available regardless of success or failureattempted = batch.len()before the async block so it's accessible in both the success and failure branchescounter.complete(attempted)(same as before, now using the tuple)failed_files += attemptedinstead of+= 1Testing