fix(update): add UpdateFrequency::Never to opt out of update checks#3199
Merged
amitksingh1490 merged 3 commits intotailcallhq:mainfrom Apr 29, 2026
Merged
fix(update): add UpdateFrequency::Never to opt out of update checks#3199amitksingh1490 merged 3 commits intotailcallhq:mainfrom
amitksingh1490 merged 3 commits intotailcallhq:mainfrom
Conversation
2 tasks
amitksingh1490
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
UpdateFrequency::Neverso users can opt out of forge's auto-update version check. Today the[update] frequencyenum has onlydaily,weekly, andalways, andauto_update: falsedoesn't help because the version check itself blocks before any prompt fires.Why this matters
The reporter on #3119 explains the use case: low-internet / OTG users want to bring up forge to check configuration or chat history without waiting on the GitHub-side update check. Setting
auto_update: falseonly suppresses the install prompt - the HTTP round-trip toupdate_informerstill runs unconditionally insideon_update, so users in poor-network conditions still pay the wall-clock cost.There was no escape value before this PR:
frequency = "always"means "check every time",dailyandweeklystill hit the network on the first invocation per window, and there was nonever.Closes #3119. (issue: #3119)
Testing
cargo test -p forge_domain -p forge_config -p forge_main-> 951 pass, 13 ignored. Includes a new round-trip test incompact.rsfor[update] frequency = "never"and a new test inupdate.rsthat asserts the early-return guard short-circuits before the informer.cargo clippy -p forge_domain -p forge_config -p forge_main --all-features --all-targets -- -D warnings-> cleancargo clippy --all-features --workspace -- -D clippy::string_slice -D clippy::indexing_slicing -D clippy::disallowed_methods-> cleanThis contribution was developed with AI assistance.