Skip to content

fix(core): table outer column padding and Card title typography#186

Merged
itsprade merged 1 commit into
mainfrom
fix/table-padding-card-title-typography
Apr 20, 2026
Merged

fix(core): table outer column padding and Card title typography#186
itsprade merged 1 commit into
mainfrom
fix/table-padding-card-title-typography

Conversation

@itsprade
Copy link
Copy Markdown
Contributor

Summary

  • Table: First column uses 24px left inset (first:pl-6), last column 24px right inset (last:pr-6); interior cells keep px-2; body cells use py-2.
  • Card: Card.Header titles use text-lg, leading-none, and text-card-foreground to align with DescriptionCard, ActivityCard, and ActionPanel.
  • ActionPanel: Removed redundant text-lg from Card.Header (layout px-8 unchanged).

Notes

  • Includes a patch changeset for @tailor-platform/app-shell.
  • Vitest snapshots for table and card updated.

Test plan

  • pnpm --filter @tailor-platform/app-shell test (table + card suites)
  • Visual check: table first/last column padding in an example app

Made with Cursor

- Table: first column pl-6, last pr-6; middle cells stay px-2; cells use py-2
- Card.Header title: text-lg + text-card-foreground to match other cards
- ActionPanel: drop redundant text-lg on Card.Header
- Update snapshots; add patch changeset

Made-with: Cursor
@itsprade itsprade merged commit 8c0eed5 into main Apr 20, 2026
4 checks passed
@itsprade itsprade deleted the fix/table-padding-card-title-typography branch April 20, 2026 04:01
itsprade added a commit that referenced this pull request May 7, 2026
Table.Cell gained `astw:first:pl-6` and `astw:last:pr-6` in PR #186 (April).
LineItems uses raw <th> for headers but had been wrapping data cells in
Table.Cell, so the data row's first/last column picked up 24px outer
padding the headers don't have, breaking horizontal alignment between
header and rows after pulling main.

Switched the data cell to a raw <td> with the same className the rest of
the LineItems table already uses for headers/rows. Symmetric again.

Also picks up an incidental workspace rename in package.json (dev:next now
filters @tailor-platform/app-shell instead of the renamed app-module).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants