chore: upgrade oxlint to ^1.64.0 and fix lint errors#251
Merged
Conversation
- Upgrade oxlint from ^1.59.0 to ^1.64.0 in pnpm workspace catalog - Fix prefer-tag-over-role: replace role="separator" with <hr>, role="list/listitem" with <ul>/<li> - Fix no-underscore-dangle: rename _contextData to contextDataStore, __pending/__value to pendingMarker/pendingValue - Suppress no-underscore-dangle for _type fields (backward compatibility)
IzumiSy
requested review from
davedc,
erickteowarang,
interacsean and
victornguyen
erickteowarang
approved these changes
May 13, 2026
Contributor
erickteowarang
left a comment
erickteowarang
left a comment
There was a problem hiding this comment.
Nice changes, much better for accessibility!
erickteowarang
pushed a commit
that referenced
this pull request
May 14, 2026
Brings in #247 (type-aware cell renderers), #248 (column align), #251 (oxlint upgrade), #253 (accessor narrowing docs), and #254 (inferColumns no longer carries an accessor). Conflicts: - types.ts: dropped the duplicate `accessor` declaration from `ColumnBase` (it now lives per-branch in `ColumnTypeBranch` per #247) and kept both new fields — `align` (from #248) and `truncate` (from this branch). Updated `truncate`'s JSDoc to describe the Tooltip wiring rather than the `title` attribute. - field-helpers.ts: kept main's spread-based `column()` so the discriminated union survives. - data-table.tsx: combined `align` and `truncate` into the same cell classes; rebuilt `content` via `col.render ?? renderTypedCell(...)` (from #247). - data-table.test.tsx / docs: kept both feature describe blocks and combined doc tables. Per @IzumiSy's review (#249), the truncate tooltip now uses the app-shell `<Tooltip>` component (with a `Tooltip.Provider` mounted at `DataTable.Root`) instead of the browser `title` attribute. The cell is wrapped in `Tooltip.Trigger` only when `accessor` returns a stringifiable primitive — objects / arrays / no accessor still apply the truncate CSS but skip the tooltip wiring. Tests: 1010 passing (was 992 + 8 new truncate tests). Lint, fmt, workspace typecheck all clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade oxlint from
^1.59.0to^1.64.0and fix new lint errors introduced by the upgrade.Changes
^1.59.0→^1.64.0jsx-a11y/prefer-tag-over-role:role="separator"→<hr>in DescriptionCardrole="list"/role="listitem"→<ul>/<li>in ActionPanelno-underscore-dangle:_contextData→contextDataStore(internal only)__pending/__value→pendingMarker/pendingValue(internal only)oxlint-disable-next-linefor_typefields (backward compatibility)