fix: replace LegacyScript with DeprecatedFeature in pipeline lint rules#2
Merged
Conversation
Contributor
Code Metrics Report
Code coverage of files in pull request scope (74.1%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request consolidates and enhances the handling of deprecated features in pipeline and TailorDB configurations. It removes the separate
legacyScriptlint rule in favor of a more flexible and comprehensivedeprecatedFeaturerule, adds new configuration options for fine-grained control, and updates documentation and test cases to reflect these changes.Lint Rule Consolidation and Configuration Enhancements:
Removed the standalone
legacyScriptlint rule and merged its functionality into thedeprecatedFeaturerule for pipelines, making deprecated script/validation checks part of a unified rule with new configuration options such asallowCELScript,allowDraft, andallowStateFlowinPipelineDeprecatedFeature(config/config.go,README.md). [1] [2] [3] [4] [5]Added
allowCELScriptandallowCELHooksoptions to the pipeline and TailorDBdeprecatedFeaturerules, allowing users to control whether certain deprecated patterns are permitted (config/config.go,README.md). [1] [2] [3] [4]Lint Logic and Messaging Updates:
deprecatedFeatureoptions, and changed warning messages for deprecated script/validation patterns to clearly state they are deprecated and recommend modern alternatives (tailor/lint.go).Documentation Improvements:
README.mdto describe the new configuration options and clarify the scope and purpose of thedeprecatedFeaturerule for pipelines, TailorDB, and StateFlow (README.md).Test Case Updates:
deprecatedFeaturerule (tailor/helper_test.go,tailor/lint_test.go). [1] [2] [3]