Skip to content

fix: replace LegacyScript with DeprecatedFeature in pipeline lint rules#2

Merged
k1LoW merged 1 commit into
mainfrom
depracate-legacy-script
Sep 8, 2025
Merged

fix: replace LegacyScript with DeprecatedFeature in pipeline lint rules#2
k1LoW merged 1 commit into
mainfrom
depracate-legacy-script

Conversation

@k1LoW
Copy link
Copy Markdown
Contributor

@k1LoW k1LoW commented Sep 8, 2025

This pull request consolidates and enhances the handling of deprecated features in pipeline and TailorDB configurations. It removes the separate legacyScript lint rule in favor of a more flexible and comprehensive deprecatedFeature rule, adds new configuration options for fine-grained control, and updates documentation and test cases to reflect these changes.

Lint Rule Consolidation and Configuration Enhancements:

  • Removed the standalone legacyScript lint rule and merged its functionality into the deprecatedFeature rule for pipelines, making deprecated script/validation checks part of a unified rule with new configuration options such as allowCELScript, allowDraft, and allowStateFlow in PipelineDeprecatedFeature (config/config.go, README.md). [1] [2] [3] [4] [5]

  • Added allowCELScript and allowCELHooks options to the pipeline and TailorDB deprecatedFeature rules, allowing users to control whether certain deprecated patterns are permitted (config/config.go, README.md). [1] [2] [3] [4]

Lint Logic and Messaging Updates:

  • Updated linting logic to use the new deprecatedFeature options, and changed warning messages for deprecated script/validation patterns to clearly state they are deprecated and recommend modern alternatives (tailor/lint.go).

Documentation Improvements:

  • Expanded documentation in README.md to describe the new configuration options and clarify the scope and purpose of the deprecatedFeature rule for pipelines, TailorDB, and StateFlow (README.md).

Test Case Updates:

  • Updated test configurations and expected warning messages to align with the new rule structure and messaging, ensuring tests reflect the merged and enhanced deprecatedFeature rule (tailor/helper_test.go, tailor/lint_test.go). [1] [2] [3]

@k1LoW k1LoW self-assigned this Sep 8, 2025
@k1LoW k1LoW added the minor label Sep 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 8, 2025

Code Metrics Report

Coverage Code to Test Ratio
33.5% 1:1.5

Code coverage of files in pull request scope (74.1%)

Files Coverage
config/config.go 0.0%
tailor/lint.go 98.5%

Reported by octocov

@k1LoW k1LoW merged commit c224de8 into main Sep 8, 2025
1 check passed
@k1LoW k1LoW deleted the depracate-legacy-script branch September 8, 2025 05:46
@github-actions github-actions Bot mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant