Skip to content

fix: replace legacy permission support to deprecated#5

Merged
k1LoW merged 1 commit into
mainfrom
deprecate-legacy-permission
Sep 8, 2025
Merged

fix: replace legacy permission support to deprecated#5
k1LoW merged 1 commit into
mainfrom
deprecate-legacy-permission

Conversation

@k1LoW
Copy link
Copy Markdown
Contributor

@k1LoW k1LoW commented Sep 8, 2025

This pull request consolidates the handling of deprecated and legacy permission patterns in TailorDB linting, streamlining configuration and messaging. The main change is the removal of the separate legacyPermission lint rule and its integration into the existing deprecatedFeature rule, both in configuration and code. Documentation and tests are updated accordingly for clarity and consistency.

Configuration and Lint Rule Simplification:

  • Removed the legacyPermission lint rule from the .patterner.yml configuration and merged its functionality into the deprecatedFeature rule for TailorDB, simplifying the config structure and reducing duplication. [1] [2]
  • Updated the deprecatedFeature rule in documentation and code to cover detection of both deprecated features and legacy permission patterns, and clarified the description and relevant documentation links. [1] [2]

Code and Test Refactoring:

  • Refactored code in tailor/lint.go to check for deprecated type and record permissions under DeprecatedFeature instead of the removed LegacyPermission, and updated warning messages to use "deprecated" terminology.
  • Updated tests in tailor/lint_test.go and test configuration in tailor/helper_test.go to use the new structure and to expect "deprecated" instead of "legacy" in warning messages. [1] [2] [3] [4]

Documentation Update:

  • Added missing workspaceID field to the example configuration in README.md for completeness.

@k1LoW k1LoW self-assigned this Sep 8, 2025
@k1LoW k1LoW added the minor label Sep 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 8, 2025

Code Metrics Report

Coverage Code to Test Ratio
33.3% 1:1.5

Code coverage of files in pull request scope (73.8%)

Files Coverage
config/config.go 0.0%
tailor/lint.go 98.4%

Reported by octocov

@k1LoW k1LoW merged commit 44b0fac into main Sep 8, 2025
1 check passed
@k1LoW k1LoW deleted the deprecate-legacy-permission branch September 8, 2025 07:38
@github-actions github-actions Bot mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant