fix(sdk): reconcile TailorDB migration label after deploy --no-schema-check#1179
Draft
toiroakr wants to merge 1 commit into
Draft
fix(sdk): reconcile TailorDB migration label after deploy --no-schema-check#1179toiroakr wants to merge 1 commit into
toiroakr wants to merge 1 commit into
Conversation
…-check Previously, running `tailor-sdk deploy --no-schema-check` from a revision whose working tree was older than the remote left the remote migration label stale. The next `deploy` then reconstructed a snapshot at a label that no longer existed in the working tree and aborted with a false "Remote schema drift detected" error. Force the migration label to the working tree's latest migration number when `--no-schema-check` is in effect, restoring the invariant that the label is always reachable from the working tree.
🦋 Changeset detectedLatest commit: f72ffe1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚡ pkg.pr.new@tailor-platform/sdk@tailor-platform/create-sdk
|
Code Metrics Report (packages/sdk)
Details | | main (0cee9fb) | #1179 (da2cf23) | +/- |
|--------------------|----------------|-----------------|-------|
+ | Coverage | 61.8% | 61.9% | +0.0% |
| Files | 362 | 362 | 0 |
| Lines | 12638 | 12647 | +9 |
+ | Covered | 7818 | 7834 | +16 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 82717 | 82876 | +159 |
+ | Test | 34475 | 34605 | +130 |Code coverage of files in pull request scope (38.9% → 40.9%)
SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk-migrationlabel to the working tree's latest migration number whentailor-sdk deploy --no-schema-checkcompletes, so the invariantlabel ≤ working_tree_maxis preserved after a rollback-style deploy.--no-schema-checkpath applied types but never updated the migration label. Deploying with--no-schema-checkfrom a revision whose working tree was older than the remote left the remote label stale; the next regulardeploythen reconstructed a snapshot at a label that no longer existed in the working tree and aborted with a falseRemote schema drift detectederror.--no-schema-check), and the reconciliation step is logged when the label actually changes.deploy/tailordb/index.test.tsand exercised by the existing--no-schema-checke2e ine2e/deploy.test.ts.