Use oxc with example and templates#353
Conversation
🦋 Changeset detectedLatest commit: 1b2fae2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report (packages/sdk)
Details | | main (90618d1) | #353 (a211460) | +/- |
|--------------------|----------------|----------------|------|
| Coverage | 48.6% | 48.6% | 0.0% |
| Files | 169 | 169 | 0 |
| Lines | 4897 | 4897 | 0 |
| Covered | 2383 | 2383 | 0 |
| Code to Test Ratio | 1:0.3 | 1:0.3 | 0.0 |
| Code | 26893 | 26893 | 0 |
| Test | 9261 | 9261 | 0 |SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
toiroakr
left a comment
There was a problem hiding this comment.
Basically, I think it's good👍
Regarding packages/create-sdk/templates, I thought a simpler rule might be okay, but is it difficult due to the migration from ESLint?
What will stop working if ESLint is removed and only oxlint is used?
|
@toiroakr If it is acceptable to ignore these rules, we can remove ESLint and use oxlint only. |
|
@riku99 |
…uild pnpm caches `pkg.pr.new` URLs in three layers (store index DB, lockfile, hoisted node_modules) and `pnpm install --force` / `update` / `--fix-lockfile` alone can't pull in a refreshed PR tarball. Adding a `?v=YYYYMMDD` query parameter to the override URL forces a new cache key. Bump this value whenever PR #353 is repushed.
The previous cache-buster (?v=20260521) ended up serving a stale build that pre-dated the dedup commit on politty's PR. Bump to ?v=20260522 to force pnpm to refetch and pick up the `_used_field_keys` tracker that de-dupes repeated `-f key=value` slots.
…be fix The refreshed build drops the `--` separator before `-S ''` so `_describe` treats the suffix as a compadd option rather than an additional name group, restoring the no-trailing-space behavior on `key=` candidates.
This PR switches
exampleandpackages/create-sdk/templates/*to useoxlintandoxfmt. Rules that are not covered by oxlint are still enforced via ESLint. Prettier has been removed so that formatting is handled solely by oxfmt. Previously,.oxfmtrc.jsonignored the entiretemplates/tree because oxfmt wasn’t used there; now that oxfmt is enabled for templates, the ignore patterns have been narrowed to skip only the generated directories.This PR includes wide-spread formatting changes (via
oxfmt), so many files are touched automatically.Below is a list of files that were manually changed (configs/scripts), with direct links: