fix: add missing parentheses to core.isDebug()#268
Merged
mpminardi merged 2 commits intotailscale:mainfrom Feb 25, 2026
Merged
Conversation
mpminardi
approved these changes
Feb 25, 2026
Member
mpminardi
left a comment
There was a problem hiding this comment.
@git-mracek thanks for the fix, and apologies for the miss here!
Member
|
FYI we'll need to do a |
Contributor
Author
|
@mpminardi Done! I've run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small but critical bug in
src/main.tsthat swallows thestderroutput of failed commands when action debug logging is disabled.The Issue:
Currently, around line 938 in the
execSilentfunction, the code checks if debug logging is off:if (!core.isDebug) {Since
core.isDebugis a function in the@actions/corepackage,!core.isDebugalways evaluates tofalse. As a result, the fallbackprocess.stderr.write(out.stderr);is never executed.When a command (like
tailscale up) fails, users only see a genericsudo failed with exit code Xinstead of the actual error message from the Tailscale CLI. This makes troubleshooting extremely difficult.The Fix:
Added the missing parentheses (
!core.isDebug()) so the function is actually called and evaluates the boolean correctly. Now, users will properly see the CLI errors in their action logs.