Skip to content

Conversation

@grahamc
Copy link
Contributor

@grahamc grahamc commented Apr 23, 2025

This patch uses Determinate Nix 3.3's feature of being able to automatically fix invalid Nix hashes in CI. I recently made this change in our fork of golinks, and thought I'd upstream it.

It means PRs like #174 won't need manually pushing fixups too. They'll still need to be closed/reopened for GHA to run tests, though. See this PR on our fork for the same issue: DeterminateSystems#21

More context: https://determinate.systems/posts/changelog-determinate-nix-331/#automatic-hash-mismatches-fixes-in-github-actions

@grahamc grahamc force-pushed the push-yzxpwksuppky branch from 8f3b2f4 to 8b63e90 Compare April 23, 2025 20:16
I recently made this change in our fork of golinks, and thought I'd upstream it.

This patch uses Determinate Nix 3.3's feature of being able to automatically fix invalid Nix hashes in CI.

More context: https://determinate.systems/posts/changelog-determinate-nix-331/#automatic-hash-mismatches-fixes-in-github-actions 

Signed-off-by: Graham Christensen <graham@grahamc.com>
@grahamc grahamc force-pushed the push-yzxpwksuppky branch from 8b63e90 to 158f7a1 Compare April 23, 2025 20:17
Signed-off-by: Graham Christensen <graham@grahamc.com>
Copy link
Member

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is really cool and should help with some of the annoyance of these kinds of changes.

@willnorris willnorris merged commit 69257dd into tailscale:main Apr 23, 2025
4 checks passed
@grahamc grahamc deleted the push-yzxpwksuppky branch April 23, 2025 20:57
@mikeodr
Copy link
Contributor

mikeodr commented Apr 24, 2025

Wow thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants