Conversation
npry
force-pushed
the
npry/ex.config_keylist
branch
5 times, most recently
from
73f4fb1 to
5078cf0
Compare
illotum
reviewed
Apr 27, 2026
npry
force-pushed
the
npry/ex.config_keylist
branch
2 times, most recently
from
f90a763 to
f7a9d48
Compare
npry
force-pushed
the
npry/ex.config_keylist
branch
from
f7a9d48 to
e44ab0c
Compare
dylan-tailscale
approved these changes
Apr 28, 2026
Collaborator
dylan-tailscale
left a comment
dylan-tailscale
left a comment
There was a problem hiding this comment.
lgtm, a couple of comment nits
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I6ad50d36b82f75cb0c0fc031b3bcdf0e6a6a6964
Have the `connected_client` helper indicate the IPs of the connected client. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I36adfc324ff828e45bdb4d899b67e8466a6a6964
Minor updates to docs: - Fix README code sample - Remove `Tailscale.Native` from generated docs (`@moduledoc false`) and make a note that it's internal and therefore perma-unstable - Fixup reflinks Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Icd8d68e01c90981f683886fb1dbade956a6a6964
npry
force-pushed
the
npry/ex.config_keylist
branch
from
e44ab0c to
9fb9fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the more-ergonomic/-conventional keyword list configuration approach for
Tailscale.connect, e.g.This also touches up docs, including removing
Tailscale.Nativefrom the generated exdoc and writing a comment noting that it should be treated as internal/perma-unstable API (there is no ability to limit module visibility on the BEAM afaik).cc @illotum — review optional but appreciated