.github/rust: don't run cargo build --release on windows for PRs#165
Merged
.github/rust: don't run cargo build --release on windows for PRs#165
cargo build --release on windows for PRs#165Conversation
This one step takes around 12 minutes on Windows specifically, making the check take way longer than on Linux. Disable it except during nightly runs. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Id33d3651f0d6dfc3066260e136fde04e6a6a6964
npry
force-pushed
the
npry/ci.rust.selective-opt
branch
from
2ef0c87 to
6eb8b22
Compare
npry
changed the title
cargo build --release on windows for prscargo build --release on windows for PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is by far the slowest step, turning it off on Windows puts the check nearly in line with Linux, and the normal dev-build tells us that it compiles anyway. The
--releasecompile still runs for checks run in any other context than PRs.Arguably we should turn off Rust checks on Windows for PRs entirely though (along the same lines as macos), since it can take a forever to grab a Windows runner at all — open to that also, but this is at least an incremental improvement