util/linuxfw, wgengine: allow ingress to magicsock UDP port on Linux #10370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates #9084. Currently, we have to tell users to manually open UDP ports on Linux when certain firewalls (like ufw) are enabled. This change automates the process of adding and updating those firewall rules as magicsock changes what port it listens on. Signed-off-by: Naman Sood <mail@nsood.in>
tendstofortytwo
force-pushed
the
naman/linuxfw-magicsock-port-rule
branch
from
8524910 to
15d5e0d
Compare
catzkorn
reviewed
Nov 24, 2023
Signed-off-by: Naman Sood <mail@nsood.in>
Signed-off-by: Naman Sood <mail@nsood.in>
tendstofortytwo
requested review from
twitchyliquid64
and removed request for
raggi
twitchyliquid64
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
This all looks great! Have you had a chance to test this on a variety of linux distros? No better test coverage than tests that arent tests lol
And afaict youre mostly changing the wiring in userspace.go - that should apply to use in both tailscaled.go and tsnet.go, but maybe double check the way that tsnet initializes all the subsystems is compatible with your changes?
Signed-off-by: Naman Sood <mail@nsood.in>
|
@twitchyliquid64 tested on arch+no firewall, fedora+firewalld, and ubuntu+ufw, seems to correctly create the iptables/nftables rules in all of those cases. looking at tsnet/tsnet.go, it seems like tsnet uses a fake router, not the linux one, so this should not affect tsnet at all, I think? |
|
Excellante! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #9084.
Currently, we have to tell users to manually open UDP ports on Linux when certain firewalls (like ufw) are enabled. This change automates the process of adding and updating those firewall rules as magicsock changes what port it listens on.