client/web: small tweaks for small screens #10463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonovawolf
approved these changes
Dec 5, 2023
client/web/src/components/app.tsx
Outdated
| <WebClient auth={auth} newSession={newSession} /> | ||
| )} | ||
| </main> | ||
| <div className="px-2"> |
There was a problem hiding this comment.
Why not put px-2 on the body?
There was a problem hiding this comment.
no great reason. I was thinking about keeping all of the styling within the App component, but I guess that doesn't really buy us anything. moved to body.
| return ( | ||
| <> | ||
| <div className="flex justify-between items-center mb-12"> | ||
| <div className="flex justify-between items-center mb-9 md:mb-12"> |
There was a problem hiding this comment.
Do you need both justify-between and items-center?
There was a problem hiding this comment.
yes, they control spacing on different axes.
Add left and right padding around entire client so that the cards don't run into the side of the screen. Also tighten up vertical spacing in couple of places. Updates #10261 Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/webclient-mobile
branch
from
81a8496 to
65549d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add left and right padding around entire client so that the cards don't run into the side of the screen. Also tighten up vertical spacing around header.
There's probably more we could do, like lessen the side padding inside the cards, but I'm just starting with the most glaring issues.
Updates #10261