client/systray: allow specifying tailscaled socket #16774
Conversation
Pass a local.Client to systray.Run, so we can use the existing global localClient in the cmd/tailscale CLI. Add socket flag to cmd/systray. Updates #1708 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
| "flag" | ||
|
|
||
| "tailscale.com/client/local" | ||
| "tailscale.com/client/systray" | ||
| "tailscale.com/paths" | ||
| ) | ||
|
|
||
| var socket = flag.String("socket", paths.DefaultTailscaledSocket(), "path to tailscaled socket") | ||
|
|
||
| func main() { | ||
| new(systray.Menu).Run() | ||
| flag.Parse() | ||
| lc := &local.Client{Socket: *socket} | ||
| new(systray.Menu).Run(lc) |
There was a problem hiding this comment.
Do we need to keep this cmd entry point around when we can launch through the tailscale cli and now need the localClient? Don't think there's any harm in having it here, mostly for consistency for users.
There was a problem hiding this comment.
there was a slack discussion some time ago about the strategy here. The decision was to only include the subcommand on linux builds, since it's a little confusing to include it on macOS and Windows where there are more complete desktop clients. But if users really want to use the systray app for whatever reason, we wanted to make it relatively simple to do so... hence keeping cmd/systray around. We'll make this clearer in docs, both in the cmd/systray README as well as the eventual KB article.
2 participants
Pass a local.Client to systray.Run, so we can use the existing global localClient in the cmd/tailscale CLI. Add socket flag to cmd/systray.
Updates #1708
Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d