k8s-operator: send operator logs to tailscale #17110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbond
force-pushed
the
davidb/k8s-operator-control-logging
branch
5 times, most recently
from
6e15213 to
a0201b3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChaosInTheCRD
approved these changes
Sep 16, 2025
|
Sorry I gave this approval because lgtm, but I'm gonna test it myself just to be sure! |
ChaosInTheCRD
previously requested changes
Sep 16, 2025
davidsbond
dismissed
ChaosInTheCRD’s stale review
Accidental approval/request
ChaosInTheCRD
approved these changes
Sep 16, 2025
davidsbond
force-pushed
the
davidb/k8s-operator-control-logging
branch
from
a0201b3 to
133ead6
Compare
tomhjp
reviewed
Sep 18, 2025
davidsbond
force-pushed
the
davidb/k8s-operator-control-logging
branch
2 times, most recently
from
9b5345f to
126f0ff
Compare
tomhjp
reviewed
Sep 22, 2025
davidsbond
force-pushed
the
davidb/k8s-operator-control-logging
branch
2 times, most recently
from
34d5faa to
84b493b
Compare
This commit modifies the k8s operator to wrap its logger using the logtail logger provided via the tsnet server. This causes any logs written by the operator to make their way to Tailscale in the same fashion as wireguard logs to be used by support. This functionality can also be opted-out of entirely using the "TS_NO_LOGS_NO_SUPPORT" environment variable. Updates tailscale/corp#32037 Signed-off-by: David Bond <davidsbond93@gmail.com>
davidsbond
force-pushed
the
davidb/k8s-operator-control-logging
branch
from
84b493b to
c6f410c
Compare
tomhjp
approved these changes
Sep 22, 2025
Comment on lines
+23
to
+24
| // We use a tee logger here so that logs are written to stdout/stderr normally while at the same time being | ||
| // sent upstream. |
There was a problem hiding this comment.
nit: this comment is sort of redundant as it's covered by the good comment on the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the k8s operator to wrap its logger using the logtail
logger provided via the tsnet server. This causes any logs written by
the operator to make their way to Tailscale in the same fashion as
wireguard logs to be used by support.
This functionality can also be opted-out of entirely using the
"TS_NO_LOGS_NO_SUPPORT" environment variable.
Updates https://github.com/tailscale/corp/issues/32037