net/netmon: handle net.IPAddr types during interface address parsing #17523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
approved these changes
Oct 10, 2025
updates #16836 Android's altNetInterfaces implementation now returns net.IPAddr types which netmon wasn't handling. Adding some logging so we can see the actual link delta changes in logs. The only visible indication of this in our logs was control client never unpausing. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
barnstar
force-pushed
the
jonathan/android_netmon
branch
from
2fc4db0 to
2d286c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates #16836
Android's altNetInterfaces implementation now returns net.IPAddr types which netmon wasn't handling resulting in netmon thinking android had no interfaces at all, leading to a predictably bad time.