disco,net/tstun,wgengine/magicsock: probe and record peer MTU #9657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this could probably use more (any) tests but wanted to get this out there for review while I worked on them. |
valscale
force-pushed
the
valscale/probeMTU
branch
from
f7dd770 to
8da0ff5
Compare
icio
reviewed
Oct 4, 2023
knyar
reviewed
Oct 5, 2023
valscale
force-pushed
the
valscale/probeMTU
branch
from
8da0ff5 to
3ad2bb9
Compare
valscale
force-pushed
the
valscale/probeMTU
branch
from
3ad2bb9 to
6f6ad10
Compare
sailorfrag
approved these changes
Oct 5, 2023
valscale
force-pushed
the
valscale/probeMTU
branch
4 times, most recently
from
b72bddd to
8827cc3
Compare
|
Update: I removed the entire concept of max probed MTU from this PR since that won't be necessary until the PTB generation PR. I removed any modification of the MTUs to probe - it's such a tiny optimization and we can add it later if necessary. And I split the current usage of default TUN MTU into "what to set the tailscale TUN to" and "what is the safe value to assume that the wire MTU is if we have no information about the path." |
knyar
approved these changes
Oct 6, 2023
raggi
approved these changes
Oct 6, 2023
Automatically probe the path MTU to a peer when peer MTU is enabled, but do not use the MTU information for anything yet. Updates #311 Signed-off-by: Val <valerie@tailscale.com>
Record the number of MTU probes sent, the total bytes sent, the number of times we got a successful return from an MTU probe of a particular size, and the max MTU recorded. Updates #311 Signed-off-by: Val <valerie@tailscale.com>
valscale
force-pushed
the
valscale/probeMTU
branch
from
8827cc3 to
a457f27
Compare
|
Quick update to use @raggi's nice new syncs.LoadOrInit(). |
raggi
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disco,net/tstun,wgengine/magicsock: probe and record peer MTU
Automatically probe and record the path MTU to a peer when peer MTU is enabled,
but do not use the MTU information for anything other than metrics yet.
Updates #311