form.go, notifyicon.go: Improved tracking of modal loops#126
Merged
Conversation
For Form, we add a new event that is published if EnterMode is called. For NotifyIcons, we move tracking whether existing context menus are active to handlers for WM_ENTERMENULOOP and WM_EXITMENULOOP, as these messages give us more precise notification as to when menu(s) are present. We also change the tracking variable from a bool to an int, since Win32 APIs to permit nested context menus when specific flags are provided. We also pick up the latest revision of win. Updates tailscale/corp#26617 Signed-off-by: Aaron Klotz <aaron@tailscale.com>
nickkhyl
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Form, we add a new event that is published if EnterMode is called.
For NotifyIcons, we move tracking whether existing context menus are active to handlers for WM_ENTERMENULOOP and WM_EXITMENULOOP, as these messages give us more precise notification as to when menu(s) are present. We also change the tracking variable from a bool to an int, since Win32 APIs to permit nested context menus when specific flags are provided.
We also pick up the latest revision of win.
Updates https://github.com/tailscale/corp/issues/26617