Update SvelteKit guide #1266
Merged
Update SvelteKit guide #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to add `svelte-preprocess` and configure it to stop Svelte’s CSS parsing from breaking when applying utilities like `dark:bg-white` since it breaks on the `:`. Ideally we wouldn’t need this but, at least for now, we do.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS grammar allows any characters that are not
;or{as part of an at-rule "preamble" but Svelte's CSS parsing breaks on at-rules containing a:when nested inside rules. This situation occurs when user's apply classes with variants, for example,@apply dark:bg-white. To combat this we need to addsvelte-preprocessand configure it run postcss on<style>blocks before svelte has a chance to analyze the CSS. It'd be great to not need this but, at least for now, we do.Fixes #1221