Conversation
Swap factory parameter types from PaneBackend to MultiplexerBackend so any backend implementing the interface (TmuxBackend today, ZellijBackend in Phase 3) can be wired into the adapter registry. The PaneBackend type alias is retained as type-only (the const alias was dropped because it shadowed the type alias under TypeScript's annotation resolution). Construction sites switch to new TmuxBackend() directly. Tests: 870/870 across all packages pass; full typecheck clean (adapters / mcp / cli / core / store / project-config / agent-profiles).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #404. Final piece of Phase 1: adapter factories now accept
the abstract
MultiplexerBackendinterface so any backendimplementing it can be wired in. Phase 1 is now complete; the
public surface still names a tmux-flavoured backend everywhere
that mattered before, with
PaneBackendretained as a type-onlyalias for in-package consumers.
The const-aliased
PaneBackend = TmuxBackendwas dropped (itshadowed the type alias when TypeScript resolved annotations like
panes: PaneBackend). Construction sites usenew TmuxBackend()directly.
Test plan
project-config, agent-profiles)
Phase 1 status after this PR