P2.1: Add attach_command to TaskStatusView (multiplexer Phase 2)#428
Merged
P2.1: Add attach_command to TaskStatusView (multiplexer Phase 2)#428
Conversation
Add attach_command: { argv: string[] } | null to TaskStatusView,
populated from MultiplexerBackend.attachCommand. attach_hint
remains as a derived string ("argv joined by spaces") during the
deprecation window so existing consumers keep working. P5.1 (#422)
removes attach_hint after the deprecation release.
Both fields are populated together: when supports_attach is false
or the task is terminal, attach_hint is undefined and
attach_command is null. Adapter contract test asserts they agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #405. Add
attach_command: { argv: string[] } | nulltoTaskStatusView, populated fromMultiplexerBackend.attachCommand.The legacy
attach_hint: stringis kept and derived asargv.join(" ")so existing consumers continue to work during thedeprecation window. P5.1 (#422) removes the legacy field after a
minor release passes.
Test plan
they agree (argv joined matches the hint string)
undefined, attach_command null)