Conversation
Closed
Owner
Author
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves the user's width, FPS, and quality settings so they're restored on next use.
Changes:
Web (LocalStorageAdapter)
Replaces the in-memory InMemoryStorageAdapter with a localStorage-backed implementation. Settings are keyed as gifit_config_* and default to original values (420px, 10fps, quality 5) when absent.
Persistence trigger moved to generation
Settings are now saved when the user clicks "Generate" (in App.tsx) rather than on every input change. This reduces storage churn and only persists settings the user actually used.
configurationPanelStore cleanup:
Removed per-input setWidth/setFps/setQuality calls. handleVideoLoadedData now caps the stored width to the video's native width to avoid upscaling.
Extension: No functional change — the extension already used extensionStorage for persistence; just cleaned up a stale comment in extension.ts.
Tests updated to reflect the new persistence model and corrected mock adapter shape.