fix: replace KEYS with SCAN in RedisCache.ListQueues to prevent blocking#71
Merged
lucasoares merged 3 commits intomainfrom Nov 12, 2025
Merged
fix: replace KEYS with SCAN in RedisCache.ListQueues to prevent blocking#71lucasoares merged 3 commits intomainfrom
lucasoares merged 3 commits intomainfrom
Conversation
Co-authored-by: lucasoares <10624972+lucasoares@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace KEYS * with SCAN in Housekeeper to avoid Redis lock
Replace KEYS with SCAN in RedisCache.ListQueues to prevent blocking
Nov 12, 2025
cezar-tech
approved these changes
Nov 12, 2025
lucasoares
reviewed
Nov 12, 2025
Co-authored-by: lucasoares <10624972+lucasoares@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace KEYS * with SCAN in Housekeeper to avoid Redis lock
Plan
Implementation Summary
Successfully replaced
cache.Client.Keys(context.Background(), searchPattern)with SCAN ininternal/queue/cache/redis_cache.go:Key Changes:
Test Results:
New Tests Added:
TestListQueuesWithManyCachedQueuesIntegration- Creates 1500 queues to properly test SCAN pagination across multiple batches (batch size is 1000)TestListQueuesWithSpecificPatternIntegration- Validates pattern matching with SCANImpact
This change improves Redis performance and stability by preventing potential locks caused by the KEYS * command, especially important when dealing with large numbers of queue keys.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.