Fix timeout error and add --json flag#19
Merged
takitsu21 merged 3 commits intotakitsu21:mainfrom Jun 16, 2025
Merged
Conversation
If a test takes longer than 5 seconds, previously it would raise a timeout error.
Until tests for UI are written, it seems a little weird to decrease the fail_under value for each UI addition. I've also removed some linter ignores that were no longer needed.
takitsu21
reviewed
Jun 16, 2025
Owner
takitsu21
left a comment
takitsu21
left a comment
There was a problem hiding this comment.
Hey Steve, indeed it was known bug, I didn't took the time to fix it.
Thank you for your contribution ! For the fail_under it's ok don't worry, I will merge it asap.
takitsu21
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Dylann,
I fixed a bug where httpx would raise a timeout error if a speedtest takes longer than 5 seconds.
I've also added a
--jsonflag for JSON only output, since I'm planning on using this with telegraf.Additionally, I commented out the
fail_undervalue in the tests, since it dropped to 40% with my changes. I'm of the opinion that until tests for UI are written, it seems a little weird to decrease the fail_under value for each UI addition; but feel free re-add it if you disagree.I've also removed some linter ignores that didn't seem to be needed.
Thanks,
Steve