Skip to content

refactor(platform): add typed return union for executeSqlIntegration#1099

Merged
yannickmonney merged 1 commit into
mainfrom
refactor/typed-sql-integration-return
Apr 7, 2026
Merged

refactor(platform): add typed return union for executeSqlIntegration#1099
yannickmonney merged 1 commit into
mainfrom
refactor/typed-sql-integration-return

Conversation

@yannickmonney
Copy link
Copy Markdown
Contributor

Summary

  • Add SqlExecutionResult discriminated union type with success/error variants
  • Replace untyped results with proper TypeScript types for SQL integration execution

Fixes #95

Add SqlExecutionResult discriminated union type with success/error
variants instead of untyped results.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Warning

Rate limit exceeded

@yannickmonney has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 14 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 16 minutes and 14 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 78b529f7-3256-4c6d-9e1a-12cce0d089f3

📥 Commits

Reviewing files that changed from the base of the PR and between 968ee98 and a101e8c.

📒 Files selected for processing (2)
  • services/platform/convex/workflow_engine/action_defs/integration/helpers/execute_sql_integration.ts
  • services/platform/convex/workflow_engine/action_defs/integration/integration_action.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/typed-sql-integration-return

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@yannickmonney yannickmonney merged commit 24fe8a7 into main Apr 7, 2026
20 of 24 checks passed
@yannickmonney yannickmonney deleted the refactor/typed-sql-integration-return branch April 7, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement(types): Add typed return union for executeSqlIntegration

1 participant