Skip to content

revert: remove navigation links between login and signup pages#1249

Merged
yannickmonney merged 2 commits into
mainfrom
revert/signup-login-links
Apr 9, 2026
Merged

revert: remove navigation links between login and signup pages#1249
yannickmonney merged 2 commits into
mainfrom
revert/signup-login-links

Conversation

@yannickmonney
Copy link
Copy Markdown
Contributor

@yannickmonney yannickmonney commented Apr 9, 2026

Summary

Test plan

  • Verify login page no longer shows signup link
  • Verify signup page no longer shows login link
  • Verify login and signup flows still work correctly

Summary by CodeRabbit

  • UI Changes
    • Removed direct navigation links from authentication pages that allowed quick switching between login and signup forms.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d857a53e-0dee-465c-9dc6-ef85145cd923

📥 Commits

Reviewing files that changed from the base of the PR and between 69db2b5 and fbdbd03.

📒 Files selected for processing (3)
  • services/platform/app/routes/_auth/log-in.tsx
  • services/platform/app/routes/_auth/sign-up.tsx
  • services/platform/messages/en.json
💤 Files with no reviewable changes (1)
  • services/platform/app/routes/_auth/log-in.tsx

📝 Walkthrough

Walkthrough

This pull request removes the reciprocal navigation UI elements between the login and signup pages. Specifically, it eliminates the "no account? sign up" link from the login page and the "have an account? log in" link from the signup page, along with their corresponding internationalization string definitions. Programmatic navigation logic using useNavigate is preserved unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change—removing navigation links between login and signup pages—and clearly communicates the reversal of a previous change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/signup-login-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannickmonney yannickmonney merged commit 0bf429a into main Apr 9, 2026
24 checks passed
@yannickmonney yannickmonney deleted the revert/signup-login-links branch April 9, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant