Skip to content

feat(platform): filter model selector to only show chat-tagged models#1277

Merged
larryro merged 1 commit into
mainfrom
feat/filter-chat-models-by-tag
Apr 10, 2026
Merged

feat(platform): filter model selector to only show chat-tagged models#1277
larryro merged 1 commit into
mainfrom
feat/filter-chat-models-by-tag

Conversation

@larryro
Copy link
Copy Markdown
Collaborator

@larryro larryro commented Apr 10, 2026

Summary

  • Filter the chat page model selector to only display models with the chat tag
  • Models without the chat tag (e.g., embedding-only models) are now excluded from the dropdown
  • Adds a filteredModels memo that filters supportedModels by checking each model's tags from the provider config

Closes #1258

Test plan

  • Open the chat page and verify only models with the chat tag appear in the model selector dropdown
  • Verify embedding-only models are hidden from the selector
  • Verify model override persistence still works correctly after filtering
  • Verify stale overrides are cleared when the selected model no longer passes the filter

Summary by CodeRabbit

  • Bug Fixes
    • Model selector now displays only chat-compatible models, ensuring users can only select appropriate options for chat functionality.

The model dropdown on the chat page now filters the agent's supported
models list to only display models that have the "chat" tag, preventing
embedding-only or other non-chat models from appearing in the selector.

Closes #1258
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@larryro larryro merged commit a4ced75 into main Apr 10, 2026
23 of 24 checks passed
@larryro larryro deleted the feat/filter-chat-models-by-tag branch April 10, 2026 02:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This change modifies the model-selector component to filter the list of available models for chat functionality. The component now derives a filteredModels array from supportedModels by keeping only models that have the 'chat' tag in their metadata. This filtered list is then used throughout the component for default model selection, override validation, read-only state determination, and the rendered options list, while tag icon rendering and display-name lookups continue to reference the full modelInfoMap.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and accurately summarizes the main change: filtering the model selector to show only chat-tagged models.
Linked Issues check ✅ Passed The code changes directly address issue #1258 by filtering out embedding-only models from the chat page model selector using the 'chat' tag.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing the model filtering requirement; no out-of-scope modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/filter-chat-models-by-tag

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qwen3 Embedding 4B returns an error when responding to questions - Something went wrong

1 participant