Skip to content

fix(platform): fix vendor list UI with pagination and split columns#1313

Merged
yannickmonney merged 1 commit into
mainfrom
fix/vendor-list-ui
Apr 10, 2026
Merged

fix(platform): fix vendor list UI with pagination and split columns#1313
yannickmonney merged 1 commit into
mainfrom
fix/vendor-list-ui

Conversation

@yannickmonney
Copy link
Copy Markdown
Contributor

@yannickmonney yannickmonney commented Apr 10, 2026

Summary

  • Split the combined name/email column into two separate columns matching the customer table pattern (name with variant="label", email with variant="body")
  • Added displayMode: 'pagination' to useListPage for proper pagination controls
  • Removed unused Stack import from vendor table config

Closes #1305

Summary by CodeRabbit

  • New Features

    • Added email column to the vendors table to display vendor contact information
  • UI Changes

    • Reorganized the vendors table with optimized column sizing and layout adjustments
    • Implemented explicit pagination display mode for navigating the vendors list

Split the combined name/email column into separate columns matching
the customer table pattern, and enable pagination display mode.
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 80a89b98-e784-46ef-a420-e5421ac3fd19

📥 Commits

Reviewing files that changed from the base of the PR and between 76038fd and 6c1b49c.

📒 Files selected for processing (2)
  • services/platform/app/features/vendors/components/vendors-table.tsx
  • services/platform/app/features/vendors/hooks/use-vendors-table-config.tsx

📝 Walkthrough

Walkthrough

This change addresses UI flaws in the vendor list by introducing pagination and restructuring table columns. The vendors-table.tsx file now explicitly enables pagination by adding displayMode: 'pagination' to the list configuration. The use-vendors-table-config.tsx file splits the previously combined name/email display into separate columns: the name column is reduced in width from 408 to 200 pixels and now displays only the vendor name, while a new email column with a dedicated cell renderer is introduced with 240 pixels width to display the vendor's email or a fallback localized message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: adding pagination and splitting the name/email columns in the vendor list UI.
Linked Issues check ✅ Passed All coding requirements from issue #1305 are addressed: pagination enabled via displayMode, name/email columns split with proper styling variants matching customer list, and correct data displayed.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objectives and the requirements in issue #1305; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vendor-list-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannickmonney yannickmonney merged commit ff6291c into main Apr 10, 2026
24 checks passed
@yannickmonney yannickmonney deleted the fix/vendor-list-ui branch April 10, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Flaws on the vendor list

1 participant