fix(platform): add success variant to toast notifications#1317
Conversation
Add variant: 'success' to toast calls for vendor import, customer import, product import (both clean and partial success), product deletion, and RAG indexing retry. Also add missing product delete success toast with translation keys in en.json and de.json.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis pull request adds success toast variant styling to import and deletion operations across customers, products, and vendors modules, and refactors the product import workflow from sequential per-item creation to a single bulk creation operation. The bulk create mutation processes products sequentially, aggregates success/failure counts, and captures structured error information including error codes. Localization messages are updated to use new variable names ( Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Replace Promise.allSettled with individual createProduct calls with a single bulkCreateProducts mutation, matching the vendor/customer pattern for consistent error handling and better performance.
Align vendor, customer, and product import dialogs to use the same code flow: bulkCreate call, error code lookup in none-imported block, consistent ICU successDescription params, and unified catch handling.
1 participant
Summary
variant: 'success'to vendor import, customer import, product import, and RAG indexing retry toast notifications so they display the green CheckCircle2 iconvariant: 'destructive'tovariant: 'success'actions.deleteSuccesstranslation key in en.json and de.jsonCloses #1303, closes #1304, closes #1284, closes #1283
Summary by CodeRabbit
New Features
Improvements
Localization