chore: fix OData escaping and consistent userId in auth#374
Merged
Conversation
📝 WalkthroughWalkthroughThis PR systematically updates how user identity is derived across multiple mutation and query functions in the Convex platform services. The primary change replaces the userId source from Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Comment |
5 tasks
yannickmonney
pushed a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authUser.userId ?? ''withString(authUser._id)across 11 call sites to match the pattern used everywhere else, preventing silent empty-string userId lookupsChanged files
convex/onedrive/list_files.ts— escape'to''before OData queryconvex/documents/mutations.ts— 3 occurrencesconvex/documents/queries.ts— 2 occurrencesconvex/tone_of_voice/mutations.ts— 1 occurrenceconvex/tone_of_voice/queries.ts— 2 occurrencesconvex/websites/queries.ts— 2 occurrencesconvex/integrations/queries/list.ts— 1 occurrenceTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Improvements