chore(platform): remove offline/PWA support#483
Conversation
Remove service worker, offline provider, and all related components, hooks, and libraries. Drops vite-plugin-pwa and workbox dependencies.
📝 WalkthroughWalkthroughThis pull request removes the entire offline-first and service worker infrastructure from the application. Specifically, it deletes: UI components for offline status and sync indicators, React hooks for online status and mutation synchronization, offline data persistence modules using Dexie with cache and mutation queue management, service worker registration and Workbox-based caching logic, related TypeScript type definitions, Vite PWA plugin configuration, and all associated test files. The removal includes updates to root routing to eliminate provider wrappers. Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
services/platform/package.json (1)
83-83:⚠️ Potential issue | 🟠 MajorRemove unused
dexiedependency to fix lint.CI already reports
dexieas unused; with offline modules removed, it should be dropped fromdependencies(or explicitly ignored if still needed elsewhere).🧹 Proposed fix
- "dexie": "^4.2.1",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@services/platform/package.json` at line 83, Remove the unused "dexie" entry from the package.json "dependencies" object to satisfy the linter: locate the "dexie" dependency listed under "dependencies" and delete that key/value pair (or if the package is truly only used in dev tooling, move it into "devDependencies"); do not change other dependency entries and run the linter/CI to verify the warning is resolved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@services/platform/package.json`:
- Line 83: Remove the unused "dexie" entry from the package.json "dependencies"
object to satisfy the linter: locate the "dexie" dependency listed under
"dependencies" and delete that key/value pair (or if the package is truly only
used in dev tooling, move it into "devDependencies"); do not change other
dependency entries and run the linter/CI to verify the warning is resolved.
Remove leftover dexie dependency, workbox-* ignore, and offline entry pattern that were missed in the PWA removal.
Greptile SummaryThis PR removes all offline/PWA support by deleting service workers, offline components, hooks, and library modules. Key changes:
Minor cleanup needed:
The removal is otherwise clean with no remaining imports or references to the deleted modules found in the codebase. Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| services/platform/app/routes/__root.tsx | Removed OfflineProvider wrapper and ServiceWorkerManager component - clean removal |
| services/platform/package.json | Removed vite-plugin-pwa and all workbox-* dependencies - clean removal |
| services/platform/vite.config.ts | Removed VitePWA plugin import and configuration - clean removal |
| services/platform/lib/service-worker.ts | File deleted - service worker library removed |
| services/platform/public/sw.js | File deleted - service worker script removed |
Flowchart
flowchart TD
A[App Root] --> B[ThemeProvider]
B --> C[QueryClientProvider]
C --> D[Outlet]
style A fill:#e1f5ff
style D fill:#e1f5ff
subgraph Removed["Removed Components (shown for context)"]
E[OfflineProvider]
F[ServiceWorkerManager]
G[Service Worker sw.js]
H[Offline DB]
I[Mutation Queue]
J[Sync Manager]
end
style E fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
style F fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
style G fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
style H fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
style I fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
style J fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
Last reviewed commit: f9bf1b7
Additional Comments (1)
|
Summary
offline-indicator,sync-status-indicator,service-worker-manager,service-worker-update-prompt)use-mutation-queue,use-online-status,use-service-worker,use-sync-status)cache-manager,db,mutation-queue,sync-manager)vite-plugin-pwaandworkboxdependenciesTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Removed Features
Chores