Skip to content

chore(platform): remove offline/PWA support#483

Merged
larryro merged 2 commits into
mainfrom
chore/remove-offline-pwa
Feb 17, 2026
Merged

chore(platform): remove offline/PWA support#483
larryro merged 2 commits into
mainfrom
chore/remove-offline-pwa

Conversation

@larryro
Copy link
Copy Markdown
Collaborator

@larryro larryro commented Feb 17, 2026

Summary

  • Remove service worker, offline provider, and all related components, hooks, and libraries (offline-indicator, sync-status-indicator, service-worker-manager, service-worker-update-prompt)
  • Remove offline hooks (use-mutation-queue, use-online-status, use-service-worker, use-sync-status)
  • Remove offline library modules (cache-manager, db, mutation-queue, sync-manager)
  • Drop vite-plugin-pwa and workbox dependencies

Test plan

  • Verify the app starts and runs without errors
  • Confirm no remaining references to removed modules
  • Check that no PWA/service worker is registered in the browser

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Removed Features

    • Offline support and offline status indicators
    • Service worker registration, caching, and update prompts
    • Offline data synchronization capabilities
    • Application now requires an active internet connection
  • Chores

    • Removed PWA and Workbox dependencies

Remove service worker, offline provider, and all related components,
hooks, and libraries. Drops vite-plugin-pwa and workbox dependencies.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 17, 2026

📝 Walkthrough

Walkthrough

This pull request removes the entire offline-first and service worker infrastructure from the application. Specifically, it deletes: UI components for offline status and sync indicators, React hooks for online status and mutation synchronization, offline data persistence modules using Dexie with cache and mutation queue management, service worker registration and Workbox-based caching logic, related TypeScript type definitions, Vite PWA plugin configuration, and all associated test files. The removal includes updates to root routing to eliminate provider wrappers.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

  • refactor: query handling #402: Modifies services/platform/app/hooks/use-sync-status.ts to add memoization to its return value, while this PR completely removes the same hook — directly related as both target the same hook implementation.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(platform): remove offline/PWA support' directly and clearly describes the main objective of the changeset, which is the complete removal of offline and PWA functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-offline-pwa

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
services/platform/package.json (1)

83-83: ⚠️ Potential issue | 🟠 Major

Remove unused dexie dependency to fix lint.

CI already reports dexie as unused; with offline modules removed, it should be dropped from dependencies (or explicitly ignored if still needed elsewhere).

🧹 Proposed fix
-    "dexie": "^4.2.1",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@services/platform/package.json` at line 83, Remove the unused "dexie" entry
from the package.json "dependencies" object to satisfy the linter: locate the
"dexie" dependency listed under "dependencies" and delete that key/value pair
(or if the package is truly only used in dev tooling, move it into
"devDependencies"); do not change other dependency entries and run the linter/CI
to verify the warning is resolved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@services/platform/package.json`:
- Line 83: Remove the unused "dexie" entry from the package.json "dependencies"
object to satisfy the linter: locate the "dexie" dependency listed under
"dependencies" and delete that key/value pair (or if the package is truly only
used in dev tooling, move it into "devDependencies"); do not change other
dependency entries and run the linter/CI to verify the warning is resolved.

Remove leftover dexie dependency, workbox-* ignore, and offline entry
pattern that were missed in the PWA removal.
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Feb 17, 2026

Greptile Summary

This PR removes all offline/PWA support by deleting service workers, offline components, hooks, and library modules.

Key changes:

  • Removed OfflineProvider and ServiceWorkerManager from the root component
  • Deleted 4 UI components (offline-indicator, sync-status-indicator, service-worker-manager, service-worker-update-prompt)
  • Deleted 4 offline hooks (use-mutation-queue, use-online-status, use-service-worker, use-sync-status)
  • Deleted offline library modules (cache-manager, db, mutation-queue, sync-manager)
  • Removed vite-plugin-pwa and all workbox-* dependencies from package.json
  • Removed PWA plugin configuration from vite.config.ts

Minor cleanup needed:

  • index.html still references /manifest.webmanifest (line 22)
  • public/manifest.webmanifest and public/offline.html still exist

The removal is otherwise clean with no remaining imports or references to the deleted modules found in the codebase.

Confidence Score: 4/5

  • Safe to merge with minor cleanup recommended
  • The PR thoroughly removes PWA/offline functionality with no remaining code references. Minor leftover files (manifest.webmanifest, offline.html, and HTML reference) should be cleaned up but won't cause runtime issues.
  • Check services/platform/index.html for the manifest reference on line 22

Important Files Changed

Filename Overview
services/platform/app/routes/__root.tsx Removed OfflineProvider wrapper and ServiceWorkerManager component - clean removal
services/platform/package.json Removed vite-plugin-pwa and all workbox-* dependencies - clean removal
services/platform/vite.config.ts Removed VitePWA plugin import and configuration - clean removal
services/platform/lib/service-worker.ts File deleted - service worker library removed
services/platform/public/sw.js File deleted - service worker script removed

Flowchart

flowchart TD
    A[App Root] --> B[ThemeProvider]
    B --> C[QueryClientProvider]
    C --> D[Outlet]
    
    style A fill:#e1f5ff
    style D fill:#e1f5ff
    
    subgraph Removed["Removed Components (shown for context)"]
        E[OfflineProvider]
        F[ServiceWorkerManager]
        G[Service Worker sw.js]
        H[Offline DB]
        I[Mutation Queue]
        J[Sync Manager]
    end
    
    style E fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
    style F fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
    style G fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
    style H fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
    style I fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
    style J fill:#ffe1e1,stroke:#ff0000,stroke-dasharray: 5 5
Loading

Last reviewed commit: f9bf1b7

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Feb 17, 2026

Additional Comments (1)

services/platform/index.html
Remove this manifest reference - it's part of PWA functionality that's being removed

@larryro larryro merged commit 9233887 into main Feb 17, 2026
17 checks passed
@larryro larryro deleted the chore/remove-offline-pwa branch February 17, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant