Skip to content

Remove standalone approvals page#795

Merged
larryro merged 2 commits into
mainfrom
feat/remove-approvals-page
Mar 15, 2026
Merged

Remove standalone approvals page#795
larryro merged 2 commits into
mainfrom
feat/remove-approvals-page

Conversation

@larryro
Copy link
Copy Markdown
Collaborator

@larryro larryro commented Mar 15, 2026

Summary

  • Remove the dedicated approvals route, components, hooks, and types (features/approvals/, routes/dashboard/$id/approvals/)
  • Consolidate approval mutation/query logic into the chat feature
  • Update navigation items to remove the approvals link
  • Clean up related translations from en.json

Test plan

  • Verify approval cards in chat still render and function correctly (integration, workflow creation, workflow run, workflow update)
  • Confirm approvals route no longer exists and doesn't cause 404 errors in navigation
  • Check that navigation sidebar no longer shows the approvals link

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Removed approvals feature including UI components, dialogs, and table management
    • Reorganized approval mutations and actions to chat features module
    • Updated import paths across affected components
    • Removed approvals routes, navigation items, and localization entries

Remove the dedicated approvals route, components, hooks, and types.
Move approval mutation/query logic into the chat feature and update
navigation items accordingly.
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

No longer referenced after approvals feature removal.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5cdae39b-7199-4a78-8061-39bd71e5daca

📥 Commits

Reviewing files that changed from the base of the PR and between ae6f0b3 and 2e593e4.

📒 Files selected for processing (22)
  • services/platform/app/features/approvals/components/approval-detail-dialog.tsx
  • services/platform/app/features/approvals/components/approvals-navigation.tsx
  • services/platform/app/features/approvals/components/approvals.tsx
  • services/platform/app/features/approvals/components/approvals/get-approval-detail.ts
  • services/platform/app/features/approvals/components/approvals/product-list-cell.tsx
  • services/platform/app/features/approvals/components/approvals/use-approval-columns.tsx
  • services/platform/app/features/approvals/components/product-card.tsx
  • services/platform/app/features/approvals/hooks/actions.ts
  • services/platform/app/features/approvals/hooks/mutations.ts
  • services/platform/app/features/approvals/hooks/queries.ts
  • services/platform/app/features/approvals/types/approval-detail.ts
  • services/platform/app/features/chat/components/integration-approval-card.tsx
  • services/platform/app/features/chat/components/workflow-creation-approval-card.tsx
  • services/platform/app/features/chat/components/workflow-run-approval-card.tsx
  • services/platform/app/features/chat/components/workflow-update-approval-card.tsx
  • services/platform/app/features/chat/hooks/mutations.ts
  • services/platform/app/features/chat/hooks/queries.ts
  • services/platform/app/hooks/use-navigation-items.ts
  • services/platform/app/routeTree.gen.ts
  • services/platform/app/routes/dashboard/$id/approvals.tsx
  • services/platform/app/routes/dashboard/$id/approvals/$status.tsx
  • services/platform/messages/en.json
💤 Files with no reviewable changes (15)
  • services/platform/app/features/approvals/hooks/mutations.ts
  • services/platform/app/features/approvals/components/approvals.tsx
  • services/platform/app/routes/dashboard/$id/approvals.tsx
  • services/platform/app/features/approvals/components/product-card.tsx
  • services/platform/app/features/approvals/components/approvals-navigation.tsx
  • services/platform/app/features/approvals/types/approval-detail.ts
  • services/platform/app/features/approvals/components/approval-detail-dialog.tsx
  • services/platform/app/features/approvals/hooks/actions.ts
  • services/platform/app/routes/dashboard/$id/approvals/$status.tsx
  • services/platform/app/features/approvals/components/approvals/get-approval-detail.ts
  • services/platform/app/features/approvals/hooks/queries.ts
  • services/platform/app/features/approvals/components/approvals/product-list-cell.tsx
  • services/platform/messages/en.json
  • services/platform/app/routeTree.gen.ts
  • services/platform/app/features/approvals/components/approvals/use-approval-columns.tsx

📝 Walkthrough

Walkthrough

This PR removes the entire approvals feature UI from the platform application, including all related components, routes, types, and navigation. Approval-related mutation and action hooks are migrated from the approvals feature module to the chat feature module. Import statements in chat approval card components are updated to reference hooks from their new locations. Approvals navigation items and localization strings are deleted, and the generated route tree is updated to remove approvals route definitions.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove standalone approvals page' directly and accurately describes the main change: removing the dedicated approvals feature including routes, components, hooks, and types, consolidating approval logic into the chat feature.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/remove-approvals-page
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@larryro larryro merged commit 217699b into main Mar 15, 2026
17 checks passed
@larryro larryro deleted the feat/remove-approvals-page branch March 15, 2026 11:22
yannickmonney pushed a commit that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant