Skip to content

Remove verify_approval tool, file preprocessing, and fix agent stability#844

Merged
larryro merged 3 commits into
mainfrom
feat/remove-verify-approval-and-file-preprocessing
Mar 24, 2026
Merged

Remove verify_approval tool, file preprocessing, and fix agent stability#844
larryro merged 3 commits into
mainfrom
feat/remove-verify-approval-and-file-preprocessing

Conversation

@larryro
Copy link
Copy Markdown
Collaborator

@larryro larryro commented Mar 24, 2026

Summary

  • Remove the verify_approval agent tool and file preprocessing feature (beforeGenerateHook, FILE_PREPROCESSING_INSTRUCTIONS, related config/UI)
  • Use version-aware agent naming ({name}:v{version}) to isolate SDK state between agent versions, preventing corrupted state from one version affecting others
  • Add missing error field to messageMetadataValidator so the query return type matches the table schema, and fix the retry system message to reflect success on completion

Test plan

  • Verify existing agents work without verify_approval tool
  • Confirm agent version changes don't carry over stale SDK state
  • Check retry messages display correctly after successful continuation
  • Run bun run --filter @tale/platform test for affected test files

Summary by CodeRabbit

Release Notes

  • Removed Features

    • Removed the verify_approval tool from integration agent capabilities
    • Removed file preprocessing feature and related UI controls from custom agent configuration
  • Improvements

    • Enhanced error tracking and logging for agent responses
    • Improved error recovery handling in workflow execution management

larryro added 3 commits March 24, 2026 14:28
…mprove error metadata

Remove the verify_approval agent tool and file preprocessing feature
(FILE_PREPROCESSING_INSTRUCTIONS, beforeGenerateHook, related config).
Hoist key variables in generateAgentResponse to make partial data
available in the catch block for richer error metadata.
Each agent version now gets a unique name ({name}:v{version}) instead
of sharing the same name across versions. This prevents corrupted SDK
state from one version affecting others.
…n up retry message on success

Add `error` to `messageMetadataValidator` so the query return type
matches the table schema and mutation. Update the retry system message
to reflect success when continuation completes, preventing an orphaned
"Retrying…" message in the thread.
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@larryro larryro merged commit 8982d42 into main Mar 24, 2026
16 of 17 checks passed
@larryro larryro deleted the feat/remove-verify-approval-and-file-preprocessing branch March 24, 2026 06:55
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR removes support for two custom agent features: file preprocessing (filePreprocessingEnabled) and the verify_approval tool. The file preprocessing removal eliminates the field from data models, schemas, mutations, UI components, and instruction generation logic. The verify_approval tool removal deletes the tool implementation and removes it from the tool registry, system defaults, and integration agent configuration. Additionally, the PR enhances error handling in agent response generation to capture and persist error information in message metadata, and updates agent debug tags to include version numbers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the primary changes: removing verify_approval tool, removing file preprocessing, and fixing agent stability issues. It directly relates to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/remove-verify-approval-and-file-preprocessing

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant